Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set ruff compatibility check to py39 #331

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Conversation

jdeschamps
Copy link
Member

Description

ruff was enforcing compatibility with py38, which we don't support anymore. Updating the pre-commit env to py39 caused all the from typing import Dict, List, Tuple to cause errors.

This PR removes all such imports and replace them with the annotation dict, tuple or list.

Changes Made

  • Modified: Almost all files.

Related Issues


Please ensure your PR meets the following requirements:

  • Code builds and passes tests locally, including doctests
  • New tests have been added (for bug fixes/features)
  • Pre-commit passes
  • PR to the documentation exists (for bug fixes / features)

@jdeschamps jdeschamps requested review from CatEek and melisande-c and removed request for CatEek December 17, 2024 15:46
@jdeschamps jdeschamps merged commit ce71bfb into main Dec 18, 2024
18 checks passed
@jdeschamps jdeschamps deleted the jd/fix/ruff_py38 branch December 18, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter (ruff) enforces py38 although we dropped support
2 participants