Noise models for paper notebooks #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into iz/feat/nm_training
* other small style changes
…changes in the GaussianLikelihoodConfig model
jdeschamps
requested changes
Dec 1, 2024
| @@ -12,6 +13,67 @@ | |||
| # TODO this module shouldn't be in lvae folder | |||
|
|
|||
|
|
|||
| def create_histogram(bins, min_val, max_val, observation, signal): | |||
jdeschamps
approved these changes
Dec 2, 2024
CatEek
added a commit
that referenced
this pull request
Dec 5, 2024
related to #285, missed commit --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: federico-carrara <federico1.carrara@mail.polimi.it> Co-authored-by: Joran Deschamps <6367888+jdeschamps@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small refac for submission notebooks. Training code works if called explicitly. Training inside careamics needs further engineering.
NM code needs refactoring
Changes Made
Please ensure your PR meets the following requirements: