Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac: updated calibration code + moved it into a separate script #283

Merged
merged 5 commits into from
Nov 27, 2024
Merged

refac: updated calibration code + moved it into a separate script #283

merged 5 commits into from
Nov 27, 2024

Conversation

federico-carrara
Copy link
Collaborator

@federico-carrara federico-carrara commented Nov 27, 2024 •
edited
Loading

Description

  • What: Updated code related to the Calibration procedure carried out in LVAE-splitting models.
  • Why: Previous code was outdated.
  • How: Implemented changes from https://github.com/ashesh-0/Disentangle + moved code in a separate module.

Please ensure your PR meets the following requirements:

  • Code builds and passes tests locally, including doctests
  • New tests have been added (for bug fixes/features)
  • Pre-commit passes
  • PR to the documentation exists (for bug fixes / features)

@federico-carrara federico-carrara requested a review from a team November 27, 2024 10:05
jdeschamps
jdeschamps approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@jdeschamps jdeschamps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and merge it!

src/careamics/lvae_training/calibration.py Show resolved Hide resolved
@federico-carrara federico-carrara merged commit 17d113c into CAREamics:main Nov 27, 2024
17 checks passed
@federico-carrara federico-carrara deleted the fc/refac/new_calibration branch November 27, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdeschamps jdeschamps jdeschamps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@federico-carrara @jdeschamps