Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting of metric fields #437

Merged
merged 25 commits into from
Apr 22, 2024
Merged

Porting of metric fields #437

merged 25 commits into from
Apr 22, 2024

Conversation

nfarabullini
Copy link
Contributor

@nfarabullini nfarabullini commented Apr 10, 2024 •
edited
Loading

  • scalfac_dd3
  • kstart_dd3d
  • rayleigh_w
  • coeff1_dwdz_ref
  • coeff2_dwdz_ref
  • d2dexdz2_fac1_mc
  • d2dexdz2_fac2_mc

@nfarabullini nfarabullini requested a review from halungge April 10, 2024 12:20
@nfarabullini nfarabullini changed the title Porting of scalfac_dd3 and kstart_dd3d Porting of metric fields Apr 11, 2024
halungge
halungge requested changes Apr 11, 2024
View reviewed changes
model/common/src/icon4py/model/common/metrics/metric_fields.py Outdated
@field_operator
def _compute_rayleigh_w(
vct_a: Field[[KDim], wpfloat],
vct_a_1: Field[[], wpfloat],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason, why you have this as 1d field and not as a scalar wpfloat? I know its kind of the same but it looks awkward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are defined like this in other places and I wanted to be consistent. I can change it to float if that's better

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found any example of it in icon4py, I think it only exists in gt4py where there was a long discussion about it... I would change it to a wpfloat.

@nfarabullini nfarabullini requested a review from halungge April 16, 2024 13:15
@nfarabullini
Copy link
Contributor Author

cscs-ci run default

@nfarabullini
Copy link
Contributor Author

launch jenkins spack

@nfarabullini
Copy link
Contributor Author

cscs-ci run default

@nfarabullini
Copy link
Contributor Author

launch jenkins spack

@nfarabullini
Copy link
Contributor Author

cscs-ci run default
launch jenkins spack

halungge
halungge requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@halungge halungge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is mostly the compute_kstart_dd3d which is not yet correct, and I realized that I forgot to put the datatest markers on the tests in test_metric_fields.py that use serialized data. If you could add them there.

model/common/src/icon4py/model/common/metrics/metric_fields.py Outdated
@field_operator
def _compute_rayleigh_w(
vct_a: Field[[KDim], wpfloat],
vct_a_1: Field[[], wpfloat],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found any example of it in icon4py, I think it only exists in gt4py where there was a long discussion about it... I would change it to a wpfloat.

@nfarabullini
Copy link
Contributor Author

cscs-ci run default
launch jenkins spack

@nfarabullini nfarabullini requested a review from halungge April 17, 2024 14:01
@nfarabullini
Copy link
Contributor Author

cscs-ci run default
launch jenkins spack

@github-actions GitHub Actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@nfarabullini
Copy link
Contributor Author

cscs-ci run default

@nfarabullini
Copy link
Contributor Author

launch jenkins spack

@nfarabullini nfarabullini merged commit 993c6b1 into main Apr 22, 2024
5 checks passed
iomaganaris referenced this pull request in iomaganaris/icon4py Jun 18, 2024
@nfarabullini @iomaganaris
Porting of metric fields (#437)
75e49c8 
Implementation of the following metrics fields:
scalfac_dd3
kstart_dd3d
rayleigh_w
coeff1_dwdz_ref
coeff2_dwdz_ref
d2dexdz2_fac1_mc
d2dexdz2_fac2_mc
OngChia pushed a commit that referenced this pull request Jan 14, 2025
@nfarabullini
Porting of metric fields (#437)
e6235f1 
Implementation of the following metrics fields:
scalfac_dd3
kstart_dd3d
rayleigh_w
coeff1_dwdz_ref
coeff2_dwdz_ref
d2dexdz2_fac1_mc
d2dexdz2_fac2_mc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halungge halungge halungge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nfarabullini @halungge