Remove lhdiff_rcf from solve_nonhydro config #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is by default True and redundant after discussion with Anurag
OngChia
changed the title
|
cscs-ci run default |
|
launch jenkins spack |
halungge
requested changes
Apr 4, 2024
model/atmosphere/dycore/src/icon4py/model/atmosphere/dycore/nh_solve/solve_nonhydro.py
Show resolved
Hide resolved
halungge
requested changes
Apr 4, 2024
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
|
Yes. I have removed |
|
launch jenkins spack |
|
cscs-ci run default |
halungge
approved these changes
Apr 5, 2024
iomaganaris
referenced
this pull request
in iomaganaris/icon4py
Jun 18, 2024
* Remove lhdiff_rcf from diffusion and solve_nonhydro config because it is by default True and redundant after discussion with Anurag * Remove lhdiff_rcf in diffusion. lhdiff_rcf in py2fgen has to be removed too.
OngChia
added a commit
that referenced
this pull request
Jan 14, 2025
* Remove lhdiff_rcf from diffusion and solve_nonhydro config because it is by default True and redundant after discussion with Anurag * Remove lhdiff_rcf in diffusion. lhdiff_rcf in py2fgen has to be removed too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remove the option
lhdiff_rcffromsolve_nonhydroanddiffusionconfig because diffusion should only be applied at the full time step, and thus it is redundant after discussion with Anurag.