[icon4pygen]: Print error message when codegen fails in tests #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egparedes
reviewed
Mar 20, 2024
| @@ -136,7 +137,10 @@ def test_codegen(cli, stencil_module, stencil_name, flags) -> None: | |||
| with cli.isolated_filesystem(): | |||
| cli_args = [module_path, BLOCK_SIZE, LEVELS_PER_THREAD, OUTPATH, *flags] | |||
| result = cli.invoke(main, cli_args) | |||
| assert result.exit_code == 0 | |||
| if not result.exit_code == 0: | |||
| traceback.format_exception(*result.exc_info) | |||
There was a problem hiding this comment.
Suggested change
| traceback.format_exception(*result.exc_info) |
Comment on lines
140
to
143
| if not result.exit_code == 0: | ||
| traceback.format_exception(*result.exc_info) | ||
| msg = "".join(traceback.format_exception(*result.exc_info)) | ||
| pytest.fail("Codegen failed with error:\n" + msg) |
There was a problem hiding this comment.
I like more to keep the assert statement because it's way simpler to read. What about using an assert with a custom message:
Suggested change
| if not result.exit_code == 0: | |
| traceback.format_exception(*result.exc_info) | |
| msg = "".join(traceback.format_exception(*result.exc_info)) | |
| pytest.fail("Codegen failed with error:\n" + msg) | |
| assert result.exit_code == 0, f"Codegen failed with error:\n{''.join(traceback.format_exception(*result.exc_info))}" |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run default |
|
launch jenkins spack |
iomaganaris
referenced
this pull request
in iomaganaris/icon4py
Jun 18, 2024
When code generation fails we previously just printed the processes exit code in the tests. This PR forwards the exception for easier debugging.
OngChia
pushed a commit
that referenced
this pull request
Jan 14, 2025
When code generation fails we previously just printed the processes exit code in the tests. This PR forwards the exception for easier debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When code generation fails we previously just printed the processes exit code in the tests. This PR forwards the exception for easier debugging.