Add support for conafigurable userinfo_endpoint and a better error handling when this is missing #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allardhoeve
suggested changes
Apr 4, 2017
oidc_auth/authentication.py
Outdated
| @@ -68,7 +68,11 @@ def get_bearer_token(self, request): | |||
|
|
|||
| @cache(ttl=api_settings.OIDC_BEARER_TOKEN_EXPIRATION_TIME) | |||
| def get_userinfo(self, token): | |||
| response = requests.get(self.oidc_config['userinfo_endpoint'], | |||
| userinfo_endpoint = self.oidc_config.get('userinfo_endpoint', api_settings.USERINFO_ENDPOINT) | |||
| if userinfo_endpoint in ['', None, [], (), {}]: | |||
There was a problem hiding this comment.
I would rather this be if not userinfo_endpoint:, which is much more readable and probably what you want anyway.
|
@allardhoeve Can you please take a look here. |
| userinfo_endpoint = self.oidc_config.get('userinfo_endpoint', api_settings.USERINFO_ENDPOINT) | ||
| if not userinfo_endpoint: | ||
| msg = _('Invalid userinfo_endpoint URL.' | ||
| 'Not found an URL from OpenID connect discovery metadata nor settings.OIDC_AUTH.USERINFO_ENDPOINT.') |
There was a problem hiding this comment.
Could you change this to "Could not find an URL from OpenID connect discovery metadata nor settings.OIDC_AUTH.USERINFO_ENDPOINT"? Just a little nicer :)
|
Looks pretty good @wiliamsouza do you have time to rebase? |
|
I would also need this feature. Any chance we can get this merged? |
kerrermanisNL
pushed a commit
that referenced
this pull request
Apr 9, 2021
Based on PR for #20 But updated with master. Adds a possibility for users to configure a user endpoint if it cannot be discovered via OpenID connect provider discovery metadata. Also provide and error message when none could be found (including user specified one). Special thanks to @wiliamsouza
|
Closing in favour of #54 thanks again @wiliamsouza :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for configurable userinfo_endpoint and a better error handling when OpenID connect provider discovery metadata does not contain this field.