Pulldown cmark 0.4 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be a bug in pulldown-cmark that started with their v0.3.0. I've filed a bug with them: pulldown-cmark/pulldown-cmark#330
This pull request of pulldown-cmark's started stripping whitespace from table cells: pulldown-cmark/pulldown-cmark#189 (comment)
Even though the spaces are stripped from within the table cells, the pulldown-cmark events generated should be the same for the original markdown and the markdown produced by pulldown-cmark-to-cmark.
|
Thanks a lot, @carols10cents , and sorry for the late response. I will make a new release right away! |
|
0.4 is a somewhat buggy release. We should upgrade to 0.5 as soon as possible. |
|
Since merging the PR, I upgraded to 0.5.2 as well and published that
separately. A few behaviors definitely changed as indicated by the tests,
and for now I have just updated the tests expectations accordingly.
On Wed 3. Jul 2019 at 20:00, Andy Russell ***@***.***> wrote:
0.4 is a somewhat buggy release. We should upgrade to 0.5 as soon as
possible.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=ADTXPGUT7RE4HMI5JZUJIG3P5SIFFA5CNFSM4HNZLKH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZEG5SQ#issuecomment-508063434>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADTXPGTTY4A4JETMJXKG3ITP5SIFFANCNFSM4HNZLKHQ>
.
--
Sebastian Thiel 李乐乐
Rust and TWU Advocate
Email sthiel@thoughtworks.com
Telephone +49 (0) 40 300 95 880 <+49+(0)+40+300+95+880>
[image: ThoughtWorks]
<http://www.thoughtworks.com/?utm_campaign=sebastian-thiel-signature&utm_medium=email&utm_source=thoughtworks-email-signature-generator>
ThoughtWorks Deutschland GmbH Großer Burstah 46-48D-20457 Hamburg
Sitz der Gesellschaft: Hamburg Geschäftsführer: Dr. Peter Buhrmann - AG
Hamburg - HRB 115336
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on @euclio's work in #2 and I think gets all the tests passing 🤞
I had to change the fixtures and the snapshots though, see the commit messages for details.
@ehuss this is probably relevant to your interests too :)