fix(windows): fix that_detached for UNC path of a directory
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes Byron#106 This PR also fallsback to `ShellExecuteExW` if `SHOpenFolderAndSelectItems` fails
Byron
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
Thanks a million!
I will create a new release right away: https://github.com/Byron/open-rs/releases/tag/v5.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #106
Strip UNC (
\?\\) prefixes when opening directories using theduncecrate.This PR also falls back to
ShellExecuteExWin the rare case thatSHOpenFolderAndSelectItemsmight fail, very unlikely but still good to do IMO.However, I should note that
SHOpenFolderAndSelectItemsin some cases, instead of returning an error, it falls back to opening a default directory which is usually theDocumentsfolder, this PR does not fix that as the Windows API doesn't return an error for it.