gix-url fix #1402
Merged
gix-url fix #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's notable that this happens with `url` 2.5.1 which comes with `idna` 1.0. It contains many fixes, for instance it seems to not be vulnerable anymore to long input, but it fails with a seemingly simple URL.
|
@DaveLak This is a wonderful example of That would also help |
Closed
|
@Byron , thanks for the ping and the insight! This is very interesting to me! I'm planning on taking my first shot at fuzzing contributions on this repo in the second half of August, so I may very well start here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce a URL parsing overflow when using the latest version of the
urlcrate.This one probably needs to be fixed in
idna.Ideally, this would be solved by adding clusterfuzz support to the
idnacrate, for whichgitoxideis acting like a proxy now.Tasks
idnacrate.