Address (most) warnings on Clang #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classes should use override keyword to mark overriden virtual functions. Remove i_clonable macros from mygsl classes that do not use these and do not inherit from i_cloneable anyway.
Classes inhertiing from i_serializable require override of virtual get_serial_tag member function. However, some classes do not inherit this base class and so must not mark this member function as override. Create seperate macros for the override/non-override cases and apply to classes as needed.
Use override consistently for overriden virtual functions. Use tidy and ISO C++ Core Guideline C.128 so that destructors are treated the same way. See: - http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-override - isocpp/CppCoreGuidelines#1448 - isocpp/CppCoreGuidelines#1446 - isocpp/CppCoreGuidelines#721 (comment)
- Missing overrides - const auto& in loops
This was referenced Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In building Bayeux for SuperNEMO with the latest Clang compiler, a huge number of warnings are emitted through it implementing a stricter set of checks than GCC (at least up to GCC7). These are mostly straightforward and related to missing
overrides on overriden virtual functions, unused variables, and avoiding copies in range-based for loops. The remaining warnings will be noted in Issues here and bxdecay0, and cross-referenced.For reference,
clang-tidyimplements the use ofoverrideper the CPP Core Guidelines, and discussion at these links:The move from
virtual fun();tofun() override;may look odd at first, but the first link makes the rationale clear.