Fix: date interval #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davert0 Thanks for the kind words and the PR. I created a test scenario and got an error as you described. I created an Issue for the error I got #46. Please take a look and let me know if it matches what you experienced. I regards to your upper bound feature request. Please let me know if this Singer-SDK issue describes what you are needing for your large view: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @BuzzCutNorman! Thanks for fixing the incremental replication!
I found another bug when trying to download a table with a Date replication field. I have a pretty large view in my database, and if I don't specify an upper bound on the interval, the query tries to read all the data, so I added an upper interval in the future time