Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

fix: try broadcast outgoing tx again #567

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

arkadiuszos4chain
Copy link
Contributor

  • try broadcast outgoing transaction in cronjob if broadcast fails on recording transaction
  • change cron intervals for tasks

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@arkadiuszos4chain arkadiuszos4chain self-assigned this Feb 2, 2024
@arkadiuszos4chain arkadiuszos4chain requested a review from a team as a code owner February 2, 2024 09:33
@mergify mergify bot added the bug-P3 Lowest rated bug, affects nearly none or low-impact label Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a45c17) 53.85% compared to head (4145d54) 53.82%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   53.85%   53.82%   -0.03%     
==========================================
  Files         110      110              
  Lines       10831    10829       -2     
==========================================
- Hits         5833     5829       -4     
- Misses       4529     4531       +2     
  Partials      469      469              
Flag Coverage Δ
unittests 53.82% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cron_job_declarations.go 87.50% <100.00%> (ø)
sync_tx_service.go 19.69% <100.00%> (-0.50%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbb4bba...4145d54. Read the comment docs.

@arkadiuszos4chain arkadiuszos4chain merged commit ba6cea9 into master Feb 2, 2024
6 of 7 checks passed
@arkadiuszos4chain arkadiuszos4chain deleted the fix-000-failed-outgoing-broadcast branch February 2, 2024 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug-P3 Lowest rated bug, affects nearly none or low-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants