Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

fix(BUX-474): prevent panics in UnReserveUtxos and VerifyMerkleRoots #538

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Jan 16, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

This is a quick fix to prevent nil pointer dereferences, but a more comprehensive solution may be considered in the future.

@chris-4chain chris-4chain requested a review from a team as a code owner January 16, 2024 12:44
@mergify mergify bot added the bug-P3 Lowest rated bug, affects nearly none or low-impact label Jan 16, 2024
Copy link
Contributor

mergify bot commented Jan 16, 2024

Welcome to our open-source project @chris-4chain! πŸ’˜

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ba7bb1b) 53.31% compared to head (3919f38) 53.29%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
- Coverage   53.31%   53.29%   -0.02%     
==========================================
  Files         110      110              
  Lines       10840    10844       +4     
==========================================
  Hits         5779     5779              
- Misses       4596     4600       +4     
  Partials      465      465              
Flag Coverage Ξ”
unittests 53.29% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
action_utxo.go 58.09% <0.00%> (ΓΈ)
chainstate/merkle_root.go 0.00% <0.00%> (ΓΈ)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update ba7bb1b...3919f38. Read the comment docs.

@chris-4chain chris-4chain merged commit cf44cd7 into master Jan 16, 2024
9 of 11 checks passed
@chris-4chain chris-4chain deleted the fix-474-prevent-panics branch January 16, 2024 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug-P3 Lowest rated bug, affects nearly none or low-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants