Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

feat(BUX-417): remove monitor, ITC flag and IncomingTransaction #532

Merged

Conversation

pawellewandowski98
Copy link
Contributor

@pawellewandowski98 pawellewandowski98 commented Jan 11, 2024

Description

  • Removed monitor
  • Removed ITC (Internal transaction check) flag and IncomingTransaction model. ITC flag was checked only in one place -during recording external incoming transaction. After we switched to paymail transaction this check was never possible to be passed. IncomingTransaction was only used after this check and for transactions which do not have to be broadcasted right away and can be checked in cron task. Now every new transaction have to be broadcasted so main assumption for IncomingTransaction can not be performed so it is useless.

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@pawellewandowski98 pawellewandowski98 self-assigned this Jan 11, 2024
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner January 11, 2024 10:37
@mergify mergify bot added the feature Any new significant addition label Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9081074) 51.88% compared to head (c564ccc) 55.19%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
+ Coverage   51.88%   55.19%   +3.31%     
==========================================
  Files         109      104       -5     
  Lines       11250    10316     -934     
==========================================
- Hits         5837     5694     -143     
+ Misses       4946     4177     -769     
+ Partials      467      445      -22     
Flag Coverage Δ
unittests 55.19% <33.33%> (+3.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
action_destination.go 55.89% <100.00%> (+3.24%) ⬆️
chainstate/chainstate.go 76.59% <ø> (+3.12%) ⬆️
chainstate/client.go 70.45% <ø> (+4.49%) ⬆️
chainstate/client_options.go 75.53% <ø> (+7.91%) ⬆️
client.go 65.57% <ø> (+5.07%) ⬆️
client_internal.go 94.48% <ø> (+21.76%) ⬆️
client_options.go 75.30% <ø> (-0.42%) ⬇️
cron_job_declarations.go 85.00% <ø> (-2.50%) ⬇️
cron_job_definitions.go 0.00% <ø> (ø)
locks.go 100.00% <ø> (ø)
... and 5 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9081074...c564ccc. Read the comment docs.

@pawellewandowski98 pawellewandowski98 force-pushed the feat-417-remove-monitor-and-legacy-payments branch from 6692434 to 9520ba7 Compare January 11, 2024 11:01
@pawellewandowski98 pawellewandowski98 force-pushed the feat-417-remove-monitor-and-legacy-payments branch from 9520ba7 to c564ccc Compare January 12, 2024 11:39
@pawellewandowski98 pawellewandowski98 changed the base branch from master to rc-v1.1 January 12, 2024 12:29
@pawellewandowski98 pawellewandowski98 merged commit 06feaba into rc-v1.1 Jan 12, 2024
10 checks passed
@mergify mergify bot deleted the feat-417-remove-monitor-and-legacy-payments branch January 12, 2024 12:29
wregulski pushed a commit that referenced this pull request Jan 31, 2024
* chore(BUX-417): remove monitor

* chore(BUX-417): remove ITC flag

* chore(BUX-417): remove incoming tx
dorzepowski pushed a commit that referenced this pull request Feb 1, 2024
* chore(BUX-417): remove monitor

* chore(BUX-417): remove ITC flag

* chore(BUX-417): remove incoming tx
jakubmkowalski pushed a commit that referenced this pull request Feb 12, 2024
* chore(BUX-417): remove monitor

* chore(BUX-417): remove ITC flag

* chore(BUX-417): remove incoming tx
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants