Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

feat(BUX-291): initial refactorization #436

Merged

Conversation

arkadiuszos4chain
Copy link
Contributor

Context:
We need to adjust broadcasting mechanism to correctly handle BEEF p2p transactions.

Changes:
Split model_sync_transactions.go into smaller, more specialized files. Functions moved to two files: sync_tx_service.go and sync_tx_repository.go. No changes have been made to the logic.

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

Sorry, something went wrong.

@arkadiuszos4chain arkadiuszos4chain self-assigned this Oct 19, 2023
@arkadiuszos4chain arkadiuszos4chain requested a review from a team as a code owner October 19, 2023 15:02
@mergify mergify bot added the feature Any new significant addition label Oct 19, 2023
Copy link
Contributor

@dorzepowski dorzepowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that you only move around functions and didn't change anything in them?
I'm not sure, and actually this is hard do spot if some changes inside were happen.

@arkadiuszos4chain
Copy link
Contributor Author

@dorzepowski yes, I confirm. My plan is to change their logic in next PRs. I know it's not easy to track changes, but IMO this way is better and easier than one big PR with changes and moving funcs. It will also be easier to blame specyfic change using git tools if needed ;-)

@arkadiuszos4chain arkadiuszos4chain force-pushed the feat-291-change-broadcast-mechanism-init-refact branch from b2b1667 to b9fd938 Compare October 20, 2023 11:40
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #436 (e65a2fb) into master (c19ef9d) will increase coverage by 0.01%.
The diff coverage is 9.45%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   52.53%   52.55%   +0.01%     
==========================================
  Files          97       99       +2     
  Lines       10830    10827       -3     
==========================================
  Hits         5690     5690              
+ Misses       4693     4690       -3     
  Partials      447      447              
Flag Coverage Δ
unittests 52.55% <9.45%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
model_sync_transactions.go 67.17% <80.00%> (+46.61%) ⬆️
sync_tx_repository.go 34.88% <34.88%> (ø)
sync_tx_service.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c19ef9d...e65a2fb. Read the comment docs.

@arkadiuszos4chain arkadiuszos4chain force-pushed the feat-291-change-broadcast-mechanism-init-refact branch from b9fd938 to e65a2fb Compare October 25, 2023 09:09
@arkadiuszos4chain arkadiuszos4chain merged commit 31bf756 into master Oct 25, 2023
@arkadiuszos4chain arkadiuszos4chain deleted the feat-291-change-broadcast-mechanism-init-refact branch October 25, 2023 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants