Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

feat(BUX-227): npe if broadcast returned an empty response #398

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

witalij-4chain
Copy link

No description provided.

@mergify mergify bot added the bug-P3 Lowest rated bug, affects nearly none or low-impact label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #398 (60fa42e) into master (82bbc83) will decrease coverage by 0.03%.
The diff coverage is 16.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   51.96%   51.93%   -0.03%     
==========================================
  Files          92       92              
  Lines       10683    10688       +5     
==========================================
  Hits         5551     5551              
- Misses       4698     4702       +4     
- Partials      434      435       +1     
Flag Coverage Δ
unittests 51.93% <16.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
chainstate/broadcast_providers.go 44.64% <16.66%> (-4.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82bbc83...60fa42e. Read the comment docs.

Copy link
Member

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 785420a into master Sep 19, 2023
6 of 7 checks passed
@mergify mergify bot deleted the fix/broadcast-npe branch September 19, 2023 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug-P3 Lowest rated bug, affects nearly none or low-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants