Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

feat(BUX-177): prepare beef hex #395

Merged
merged 8 commits into from
Sep 19, 2023
Merged

feat(BUX-177): prepare beef hex #395

merged 8 commits into from
Sep 19, 2023

Conversation

arkadiuszos4chain
Copy link
Contributor

@arkadiuszos4chain arkadiuszos4chain commented Sep 18, 2023

Prepare a BEEF transaction for a P2P receiver who can handle it.
Works only if all inputs come from mined transactions.

@mergify mergify bot added the feature Any new significant addition label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #395 (978ef79) into master (987f698) will decrease coverage by 0.39%.
The diff coverage is 26.88%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   51.96%   51.57%   -0.39%     
==========================================
  Files          92       95       +3     
  Lines       10683    10872     +189     
==========================================
+ Hits         5551     5607      +56     
- Misses       4698     4831     +133     
  Partials      434      434              
Flag Coverage Δ
unittests 51.57% <26.88%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
beef_tx.go 0.00% <0.00%> (ø)
beef_tx_bytes.go 0.00% <0.00%> (ø)
model_sync_transactions.go 21.07% <0.00%> (+0.19%) ⬆️
model_transaction_config.go 80.98% <0.00%> (-2.55%) ⬇️
paymail.go 55.17% <0.00%> (-5.44%) ⬇️
utils/utils.go 82.60% <0.00%> (-10.08%) ⬇️
model_compound_merkle_path.go 65.51% <25.00%> (-6.86%) ⬇️
beef_tx_sorting.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 987f698...978ef79. Read the comment docs.

Copy link
Member

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkadiuszos4chain arkadiuszos4chain merged commit 8241acd into BuxOrg:master Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants