Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

feat(BUX-180): remove option to use whatsonchain and nownodes for broadcasting #389

Merged
merged 1 commit into from
Sep 14, 2023
Merged

feat(BUX-180): remove option to use whatsonchain and nownodes for broadcasting #389

merged 1 commit into from
Sep 14, 2023

Conversation

witalij-4chain
Copy link

Context:

  1. As I understood from previous discussions we should focus on providing support for common/standarized API especially Arc (and for now still support for mApi).

  2. Just as an extension to that, we have similar broadcasting support for Now Nodes, should we remove it also?

Answers:

  1. Agreed

  2. Agreed, we are specifically building on this software to avoid relying on a node. NowNodes is counter to this mission.

@mergify mergify bot added the feature Any new significant addition label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #389 (a4705b7) into master (116cc85) will decrease coverage by 0.40%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
- Coverage   52.48%   52.08%   -0.40%     
==========================================
  Files          92       92              
  Lines       10800    10749      -51     
==========================================
- Hits         5668     5599      -69     
- Misses       4694     4714      +20     
+ Partials      438      436       -2     
Flag Coverage Δ
unittests 52.08% <ø> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
chainstate/broadcast.go 88.15% <ø> (-1.73%) ⬇️
chainstate/broadcast_providers.go 49.01% <ø> (-15.03%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 116cc85...a4705b7. Read the comment docs.

Copy link
Member

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 5fcff20 into BuxOrg:master Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants