This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
fix: add unreserve utxos action #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkadiuszos4chain
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #371 +/- ##
==========================================
- Coverage 52.10% 52.06% -0.04%
==========================================
Files 90 90
Lines 10683 10683
==========================================
- Hits 5566 5562 -4
- Misses 4692 4696 +4
Partials 425 425
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Creation of a draft transaction will mark UTXOs as reserved, and those UTXOs can't be used for another transaction.
If a draft transaction was created, but the "record transaction" process failed, UTXOs will still be reserved and can't be used for another payment.
A mechanism for unreserving UTXOs should be added for such cases.