Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

feat(BUX-157): disabling of a dust limit validation for txs with OpReturn #353

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

witalij-4chain
Copy link

@witalij-4chain witalij-4chain commented Aug 7, 2023

Such txs don’t contain “money to send”, but only OpReturn. So the validation should be disabled for such cases

@witalij-4chain witalij-4chain requested a review from mrz1836 as a code owner August 7, 2023 11:04
@mergify mergify bot assigned mrz1836 Aug 7, 2023
@mergify mergify bot added the feature Any new significant addition label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #353 (f2ad897) into master (b7213a1) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   52.13%   52.10%   -0.03%     
==========================================
  Files          90       90              
  Lines       10677    10683       +6     
==========================================
  Hits         5566     5566              
- Misses       4686     4692       +6     
  Partials      425      425              
Flag Coverage Δ
unittests 52.10% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
model_draft_transactions.go 73.12% <0.00%> (-0.66%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7213a1...f2ad897. Read the comment docs.

Copy link
Member

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit c398c2a into BuxOrg:master Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants