Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

feat(BUX-51): go-minercraft v2 #339

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

witalij-4chain
Copy link

No description provided.

@witalij-4chain witalij-4chain requested a review from mrz1836 as a code owner July 23, 2023 22:45
@mergify mergify bot added the feature Any new significant addition label Jul 23, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #339 (fd495e4) into master (a20d32a) will decrease coverage by 1.78%.
The diff coverage is 38.57%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   54.15%   52.37%   -1.78%     
==========================================
  Files          90       90              
  Lines       10566    10598      +32     
==========================================
- Hits         5722     5551     -171     
- Misses       4429     4624     +195     
- Partials      415      423       +8     
Flag Coverage Δ
unittests 52.37% <38.57%> (-1.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chainstate/broadcast_providers.go 81.42% <ø> (ø)
chainstate/client_internal.go 32.87% <0.00%> (-0.93%) ⬇️
client_options.go 75.05% <0.00%> (-1.37%) ⬇️
chainstate/mock_minercraft.go 46.70% <26.00%> (-35.84%) ⬇️
chainstate/client_options.go 80.64% <42.85%> (+8.29%) ⬆️
chainstate/client.go 73.79% <63.88%> (+8.60%) ⬆️
chainstate/transaction.go 95.41% <88.88%> (ø)
chainstate/broadcast.go 93.90% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a20d32a...fd495e4. Read the comment docs.

Copy link
Member

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 6bc777f into BuxOrg:master Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants