Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Changed signature of action methods to use WithMetadatas in options #17

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

icellan
Copy link
Member

@icellan icellan commented Feb 25, 2022

instead of as a function argument

@icellan icellan requested a review from mrz1836 as a code owner February 25, 2022 13:11
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #17 (3d947c2) into master (211ac55) will increase coverage by 0.00%.
The diff coverage is 56.25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   64.71%   64.72%           
=======================================
  Files          88       88           
  Lines        7865     7860    -5     
=======================================
- Hits         5090     5087    -3     
+ Misses       2471     2470    -1     
+ Partials      304      303    -1     
Flag Coverage Δ
unittests 64.72% <56.25%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
action_access_key.go 0.00% <0.00%> (ø)
action_xpub.go 25.73% <0.00%> (-0.16%) ⬇️
import.go 0.00% <0.00%> (ø)
action_transaction.go 57.69% <50.00%> (+1.61%) ⬆️
action_destination.go 81.63% <100.00%> (ø)
model_xpubs.go 85.40% <100.00%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 211ac55...3d947c2. Read the comment docs.

@mrz1836 mrz1836 added feature Any new significant addition update General updates labels Feb 25, 2022
Copy link
Member

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 1076f89 into master Feb 25, 2022
@mergify mergify bot deleted the with-metadatas branch February 25, 2022 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition update General updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants