Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

termcolor: Write Ansi::reset() using \x1b[0m instead of \x1b[m #742

Merged
merged 2 commits into from
Jan 29, 2018

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Jan 11, 2018

AppVeyor CI supports coloring the console through ANSI escape codes, however its support is incomplete (appveyor/ci#1824). One particular issue is that \x1b[m is not recognized as the same as \x1b[0m.

This caused colored output using this library extremely ugly on AppVeyor as the color is never reset (example, start from line 675).

While technically an AppVeyor bug, I think changing the code here would improve compatibility anyway. (That issue is also untouched for 2 months so I doubt if AppVeyor is going to fix it soon.)

@BurntSushi BurntSushi merged commit 8514d4f into BurntSushi:master Jan 29, 2018
@BurntSushi
Copy link
Owner

Thanks!

@kennytm kennytm deleted the patch-1 branch January 29, 2018 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants