Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.gitignore whitespace bug #38

Closed
msarchet opened this issue Sep 23, 2016 · 1 comment
Closed

.gitignore whitespace bug #38

msarchet opened this issue Sep 23, 2016 · 1 comment
Labels
bug A bug.

Comments

@msarchet
Copy link

msarchet commented Sep 23, 2016 •
edited
Loading

If an ignored path in a .gitignore has whitespace afterwards

node_modules/   <--- whitespace

ripgrep with still search the node_modules/ folder, removing the whitespace fixes this problem.
@BurntSushi
Copy link
Owner

I buy it. From man gitignore:

Trailing spaces are ignored unless they are quoted with backslash ("\").

@BurntSushi BurntSushi added the bug A bug. label Sep 24, 2016
amsharma91 added a commit to amsharma91/ripgrep that referenced this issue Sep 27, 2016
@amsharma91
Strip trailing whitespace in gitignore patterns.
09c3329 
Fixes BurntSushi#38.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msarchet @BurntSushi