Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add support for loongarch64 targets #172

Closed
wants to merge 1 commit into from
Closed

ci: add support for loongarch64 targets #172

wants to merge 1 commit into from

Conversation

heiher
Copy link

@heiher heiher commented Jan 3, 2025

The latest release of cross does not support the LoongArch target yet. This PR switches to installing a pinned commit from Git.

heiher
heiher commented Jan 3, 2025
View reviewed changes
.github/workflows/ci.yml
@@ -122,13 +122,13 @@ jobs:
- name: Show byte order for debugging
run: ${{ env.CARGO }} test --verbose $TARGET byte_order -- --nocapture
- name: Run tests
run: ${{ env.CARGO }} test --verbose
run: ${{ env.CARGO }} test --verbose $TARGET
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this missed before this?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly, It's just a diagnostic and it's rarely anything other than little endian, so definitely easy to miss.

BurntSushi
BurntSushi requested changes Jan 3, 2025
View reviewed changes
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't want to get into the business of pinning to specific cross commits. And I don't want to add a target to CI if I can't rely on it working. Maybe Rust support for loongarch64 needs to mature a bit first.

.github/workflows/ci.yml
@@ -122,13 +122,13 @@ jobs:
- name: Show byte order for debugging
run: ${{ env.CARGO }} test --verbose $TARGET byte_order -- --nocapture
- name: Run tests
run: ${{ env.CARGO }} test --verbose
run: ${{ env.CARGO }} test --verbose $TARGET
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly, It's just a diagnostic and it's rarely anything other than little endian, so definitely easy to miss.

@heiher
Copy link
Author

heiher commented Jan 3, 2025

I really don't want to get into the business of pinning to specific cross commits. And I don't want to add a target to CI if I can't rely on it working. Maybe Rust support for loongarch64 needs to mature a bit first.

I can understand you. What I want to clarify is that having more crates support LoongArch is indeed an effective way to make it more mature, and this certainly includes the excellent project memchr.

I think it would also be fine to wait until the SIMD intrinsics for LoongArch become stable before adding CI support.

@heiher heiher closed this Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heiher @BurntSushi