Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused 'b lifetime from trait implementation macros #202

Merged

Conversation

joshtriplett
Copy link
Contributor

The macros implementing PartialEq and PartialOrd all provide lifetimes
'a and 'b to the types they receive, but none of the invocations of
these macros ever use 'b.

The macros implementing PartialEq and PartialOrd all provide lifetimes
'a and 'b to the types they receive, but none of the invocations of
these macros ever use 'b.
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@BurntSushi BurntSushi merged commit 7cd4694 into BurntSushi:master Jan 2, 2025
8 checks passed
@joshtriplett joshtriplett deleted the remove-redundant-lifetimes branch January 2, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants