ExpandConfig now respects DangerousAcceptAnyServerCertificateValidator #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! If you have implemented new functions, write about them in the readme file. |
…tAnyServerCertificateValidator
Burgyn
approved these changes
Sep 1, 2023
|
Hi @jhines-sf, thanks for your contribution. Your changes will be released in a few minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a versioned route is expanded to each individual version, the
DangerousAcceptAnyServerCertificateValidatorproperty was not being properly respected. This meant that downstream Swagger routes that used self-signed certificates were not functioning properly.This pull request should resolve that by ensuring that the property is correctly copied in the
ExpandConfigmethod.