Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LinkedSystemIDs to DuctSystem #256

Closed
wants to merge 3 commits into from
Closed

Add LinkedSystemIDs to DuctSystem #256

wants to merge 3 commits into from

Conversation

macintoshpie
Copy link
Contributor

No description provided.

@macintoshpie macintoshpie added Schema: Systems Update to systems Non-breaking Change STD 211 Mapping Related to the effort of mapping ASHRAE 211 levels to BuildingSync labels Oct 7, 2020
@macintoshpie
Copy link
Contributor Author

Note that we also have auc:LinkedPremisesOrSystem, but aren't currently using it in 3 places that include both auc:LinkedPremises and auc:LinkedSystemIDs. Do we want to replace these in 3.0?

markborkum
markborkum approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks.

@macintoshpie macintoshpie marked this pull request as draft October 8, 2020 16:27
@macintoshpie
Copy link
Contributor Author

Closing this PR as it's not necessary. I didn't realize at the time we already had auc:HeatingDeliveryID and auc:CoolingDeliveryID, which covers our use case. There is probably no need for generic systems linking for auc:DuctSystems.

@macintoshpie macintoshpie deleted the feat/duct-linked-system-ids branch November 5, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markborkum markborkum markborkum approved these changes

@corymosiman12 corymosiman12 corymosiman12 approved these changes

@nllong nllong Awaiting requested review from nllong

Assignees
No one assigned
Labels
enhancement Non-breaking Change Schema: Systems Update to systems STD 211 Mapping Related to the effort of mapping ASHRAE 211 levels to BuildingSync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@macintoshpie @markborkum @corymosiman12 @nllong