Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add notes on git naming conventions #255

Merged
merged 3 commits into from
Oct 14, 2020
Merged

docs: add notes on git naming conventions #255

merged 3 commits into from
Oct 14, 2020

Conversation

macintoshpie
Copy link
Contributor

This creates a doc for developer resources which specifies a format for writing commit messages and branch names.

markborkum
markborkum requested changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a "proposal" type.

markborkum
markborkum approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

aviveiros11
aviveiros11 approved these changes Oct 14, 2020
View reviewed changes
Copy link

@aviveiros11 aviveiros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

nllong
nllong reviewed Oct 14, 2020
View reviewed changes
docs/developer_resources.md

Pull request examples:

- `#1234 feat(schema): add MyElement to ParentElement`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

nllong
nllong approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fandidilyastic!

@nllong nllong merged commit 19710be into develop Oct 14, 2020
@nllong nllong deleted the docs/developer-resources branch October 14, 2020 14:45
@nllong nllong added Schema: Documentation Update to BuildingSync's documentation/annotations Non-breaking Change labels Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviveiros11 aviveiros11 aviveiros11 approved these changes

@corymosiman12 corymosiman12 corymosiman12 approved these changes

@nllong nllong nllong approved these changes

@markborkum markborkum markborkum approved these changes

Assignees
No one assigned
Labels
Non-breaking Change Schema: Documentation Update to BuildingSync's documentation/annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@macintoshpie @markborkum @nllong @corymosiman12 @aviveiros11