Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MeterID and ParentResourceUseID to ResourceUse #248

Merged
merged 3 commits into from
Sep 25, 2020

Conversation

macintoshpie
Copy link
Contributor

@macintoshpie macintoshpie added Schema: Reports Update to reports Non-breaking Change STD 211 Mapping Related to the effort of mapping ASHRAE 211 levels to BuildingSync labels Sep 24, 2020
BuildingSync.xsd Outdated
Comment on lines 4044 to 4060
<xs:element name="ParentResourceUseID" minOccurs="0">
<xs:annotation>
<xs:documentation>If the ResourceUse is a submeter, this element should link to the ResourceUse which this one is a submeter of</xs:documentation>
</xs:annotation>
<xs:complexType>
<xs:attribute name="IDref" type="xs:IDREF" use="required"/>
</xs:complexType>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corymosiman12 please provide better documentation if this doesn't make sense

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If this ResourceUse is intended to represent a submetered end use ('Total Lighting', 'Heating', 'Plug load', etc.), this ResourceUse should link to a parent ResourceUse that this would 'roll up to'."

Copy link
Contributor

@corymosiman12 corymosiman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor docs change

Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks.

@macintoshpie macintoshpie force-pushed the feat/resource-use-submetering branch from 0882cf4 to 7245add Compare September 25, 2020 16:26
@macintoshpie macintoshpie merged commit 3031dfd into develop Sep 25, 2020
@macintoshpie macintoshpie deleted the feat/resource-use-submetering branch September 25, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non-breaking Change Schema: Reports Update to reports STD 211 Mapping Related to the effort of mapping ASHRAE 211 levels to BuildingSync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants