Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PeakType to TimeSeries #246

Merged
merged 3 commits into from
Sep 25, 2020
Merged

Add PeakType to TimeSeries #246

merged 3 commits into from
Sep 25, 2020

Conversation

macintoshpie
Copy link
Contributor

@macintoshpie macintoshpie added Schema: Reports Update to reports Non-breaking Change STD 211 Mapping Related to the effort of mapping ASHRAE 211 levels to BuildingSync labels Sep 24, 2020
markborkum
markborkum approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks.

corymosiman12
corymosiman12 suggested changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@corymosiman12 corymosiman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor proposal change

proposals/2020/Add Peak Type.md

## Overview

This proposal is to add the `auc:PeakType` element in order to specify what type of peak a given reading is.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...auc:PeakType element as a child element of the TimeSeriesType

@macintoshpie macintoshpie merged commit dfdf990 into develop Sep 25, 2020
@macintoshpie macintoshpie deleted the feat/peak-type branch September 25, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corymosiman12 corymosiman12 corymosiman12 approved these changes

@markborkum markborkum markborkum approved these changes

@nllong nllong Awaiting requested review from nllong

Assignees
No one assigned
Labels
Non-breaking Change Schema: Reports Update to reports STD 211 Mapping Related to the effort of mapping ASHRAE 211 levels to BuildingSync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macintoshpie @markborkum @corymosiman12