Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull rate elements out as distinct element types to reduce redundancy #216

Merged
merged 4 commits into from
Aug 27, 2020

Conversation

corymosiman12
Copy link
Contributor

simple update - no change in XML document structure

@corymosiman12 corymosiman12 added the STD 211 Mapping Related to the effort of mapping ASHRAE 211 levels to BuildingSync label Aug 17, 2020
update tiered rate to include demand rate start and end dates
Copy link
Contributor

@macintoshpie macintoshpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks.

@macintoshpie macintoshpie merged commit 17eee48 into develop Aug 27, 2020
@macintoshpie macintoshpie deleted the update/rate-elements branch August 27, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non-breaking Change STD 211 Mapping Related to the effort of mapping ASHRAE 211 levels to BuildingSync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants