-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SimpleImpactAnalysis and CostCategory to PackageOfMeasures #205
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
789505c
feat(proposals): add proposal for simple impact analysis
macintoshpie 106079c
refactor(proposals): add low/no cost and capital categories
macintoshpie aaa1def
refactor(proposals): update simple impact analysis proposal
macintoshpie 7d93592
refactor(proposals): update simple impact analysis proposal
macintoshpie adb4cc6
refactor(proposals): add comment on cost category for simple impact
macintoshpie a228e18
feat(schema): add CostCategory element to PackageOfMeasures
macintoshpie bca8a2c
feat(schema): add SimpleImpactAnalysis to PackageOfMeasures
macintoshpie b64ac37
Merge branch 'develop' into feat/simple-impact-analysis-proposal
macintoshpie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| # Add Simple Impact Analysis | ||
|
|
||
| ## Overview | ||
|
|
||
| This proposal is to add the `auc:SimpleImpactAnalysis` child element to the `auc:PackageOfMeasures` element. It also includes the suggestion that we move some of the direct children of `auc:PackageOfMeasures` into a new element `auc:ComplexImpactAnalysis`. | ||
|
|
||
| ## Justification | ||
|
|
||
| Standard 211 6.1.5.c-6.1.5.g as well as 6.1.6.d-6.1.6.g requires a summary of the impact of each recommended measure. Specifically, it states: | ||
| > c. Impact on occupant comfort (improved thermal comfort, indoor air quality [IAQ], lighting quality, acoustics) | ||
| > d. Estimated cost (high, medium, low) | ||
| > e. Estimated level (high, medium, low) of annual savings | ||
| > f. Estimated level (high, medium, low) of return on investment (ROI) | ||
| > g. Priority (high, medium, low) | ||
|
|
||
| Additionally, Standard 211 is explicit in discriminating the "Low-Cost and No-Cost" recommendations (section 6.1.5) from the "Capital" recommendations (section 6.1.6), so it might not be a bad idea to add a category to specify this. | ||
|
|
||
| ## Implementation | ||
|
|
||
| ```xml | ||
| <xs:element name="PackageOfMeasures" minOccurs="0"> | ||
| <xs:complexType> | ||
| <xs:sequence> | ||
| ... | ||
| <xs:element name="SimpleImpactAnalysis"> | ||
| <xs:element name="CostCategory"> | ||
| <xs:simpleType> | ||
| <xs:restriction base="xs:string"> | ||
| <xs:enumeration value="Low-Cost or No-Cost"> | ||
| <xs:enumeration value="Capital"> | ||
| </xs:restriction> | ||
| </xs:simpleType> | ||
| </xs:element> | ||
| <xs:element name="ImpactOnOccupantComfort" type="xs:string"></xs:element> | ||
| <xs:element name="EstimatedCost" type="LowMedHighType"></xs:element> | ||
| <xs:element name="EstimatedAnnualEnergySavings" type="LowMedHighType"></xs:element> | ||
| <xs:element name="EstimatedROI" type="LowMedHighType"></xs:element> | ||
| <xs:element name="Priority" type="LowMedHighType"></xs:element> | ||
| </xs:element> | ||
| <xs:element name="ComplexImpactAnalysis"> | ||
| <!-- elements to be moved here --> | ||
| ... | ||
| </xs:element> | ||
| </xs:sequence> | ||
| </xs:complexType> | ||
| </xs:element> | ||
| ... | ||
| <xs:simpleType name="LowMedHighType"> | ||
| <xs:restriction base="xs:string"> | ||
| <xs:enumeration value="Low"/> | ||
| <xs:enumeration value="Medium"/> | ||
| <xs:enumeration value="High"/> | ||
| </xs:restriction> | ||
| </xs:simpleType> | ||
| ``` | ||
|
|
||
| ### elements moved | ||
| These elements would be moved from `auc:PackageOfMeasures` into ` auc:ComplexImpactAnalysis` | ||
| - `auc:AnnualSavingsSiteEnergy` | ||
| - `auc:AnnualSavingsSourceEnergy` | ||
| - `auc:AnnualSavingsCost` | ||
| - `auc:AnnualSavingsByFuels` | ||
| - `auc:SummerPeakElectricityReduction` | ||
| - `auc:WinterPeakElectricityReduction` | ||
| - `auc:AnnualPeakElectricityReduction` | ||
| - `auc:AnnualDemandSavingsCost` | ||
| - `auc:AnnualWaterSavings` | ||
| - `auc:AnnualWaterCostSavings` | ||
| - `auc:ImplementationPeriod` | ||
| - `auc:PackageFirstCost` | ||
| - `auc:MVCost` | ||
| - `auc:OMCostAnnualSavings` | ||
| - `auc:EquipmentDisposalAndSalvageCosts` | ||
| - `auc:ImplementationPeriodCostSavings` | ||
| - `auc:PercentGuaranteedSavings` | ||
| - `auc:ProjectMarkup` | ||
| - `auc:FundingFromIncentives` | ||
| - `auc:FundingFromTaxCredits` | ||
| - `auc:OtherFinancialIncentives` | ||
| - `auc:RecurringIncentives` | ||
| - `auc:NPVofTaxImplications` | ||
| - `auc:CostEffectivenessScreeningMethod` | ||
| - `auc:SimplePayback` | ||
| - `auc:NetPresentValue` | ||
| - `auc:InternalRateOfReturn` | ||
| - `auc:AssetScore` | ||
| - `auc:ENERGYSTARScore` | ||
|
|
||
| ## References | ||
|
|
||
| Standard 211 6.1.5.c-6.1.5.g | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be argued that this discrimination is unnecessary/redundant because we apready specify the estimated cost (high, medium, low). Something to consider.