Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/add OriginalOccupancyClassification element to Section #202

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

corymosiman12
Copy link
Contributor

No description provided.

Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corymosiman12 Changes look good, thanks.

Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Are we waiting to merge this until after 2.1 release?

@corymosiman12
Copy link
Contributor Author

corymosiman12 commented Jul 23, 2020

My understanding after this morning's meeting was that this is something to wait on until after 2.1 release (which is why I threw the DO NOT MERGE on there). @markborkum is that correct or can we get this in there before 2.1 release?

@markborkum
Copy link
Contributor

@corymosiman12 Breaking changes should wait until the next release. This PR, in its updated form, should be nonbreaking for Audit Template, so it can go ahead if @nllong also approves.

@nllong
Copy link
Member

nllong commented Jul 23, 2020

Thanks @markborkum for letting us know that this is a nonbreaking change on the Audit Template end. Let's go ahead and get it in this release then!

@nllong nllong merged commit 9d40a8d into develop Jul 23, 2020
@nllong nllong deleted the feat/original-occupancy-classification branch July 23, 2020 16:16
@nllong nllong added Schema: General General update to BuildingSync Non-breaking Change and removed DO NOT MERGE labels Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non-breaking Change Schema: General General update to BuildingSync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants