Add ReadingType Cost to TimeSeries #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #### Pros | ||
| - non-breaking change | ||
| #### Cons | ||
| - linking a cost to another reading (eg Total use) is non-trivial and must be done using Start and End Timestamps as well as the ResourceUseID's IDref. |
There was a problem hiding this comment.
linking a cost about a specific resource to either 1) a single timeseries element (cost only driven by energy consumption) or 2) multiple timeseries elements (cost driven by both energy consumption and peak demand) is non-trivial. One must:
- Find all auc:ReadingType=Cost associated with a ResourceUse
- Ensure start and end timestamps align across different auc:TimeSeries elements (i.e. the cost and the reading are referring to the same period of time).
Comment on lines
161
to
163
| <auc:IntervalTotal>123</auc:Total> | ||
| <auc:IntervalPeak>123</auc:Peak> | ||
| <auc:IntervalCost>1000</auc:Cost> |
There was a problem hiding this comment.
Fix:
<auc:IntervalTotal>123</auc:IntervalTotal>
<auc:IntervalPeak>123</auc:IntervalPeak>
<auc:IntervalCost>1000</auc:IntervalCost>
corymosiman12
suggested changes
Jul 16, 2020
macintoshpie
changed the title
nllong
reviewed
Jul 16, 2020
nllong
reviewed
Jul 20, 2020
corymosiman12
approved these changes
Jul 21, 2020
|
Waiting to fully finish 211 <> BuildingSync mapping before making final decisions about the proposal. |
macintoshpie
added
DO NOT MERGE
STD 211 Mapping
markborkum
approved these changes
Aug 26, 2020
corymosiman12
approved these changes
Aug 27, 2020
macintoshpie
changed the title
macintoshpie
added
Schema: General
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.