Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/canadian provinces #188

Merged
merged 3 commits into from
Jun 12, 2020
Merged

Feat/canadian provinces #188

merged 3 commits into from
Jun 12, 2020

Conversation

corymosiman12
Copy link
Contributor

Add Canadian provinces enums to auc:State element

markborkum
markborkum approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@nllong
Copy link
Member

nllong commented Jun 11, 2020

I think we can merge this down, @corymosiman12 ?

@nllong nllong merged commit f656aca into develop Jun 12, 2020
@nllong nllong deleted the feat/canadian_provinces branch June 12, 2020 15:11
@nllong nllong added Non-breaking Change Schema: General General update to BuildingSync labels Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markborkum markborkum markborkum approved these changes

@nllong nllong Awaiting requested review from nllong

Assignees

@nllong nllong

Labels
Non-breaking Change Schema: General General update to BuildingSync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corymosiman12 @nllong @markborkum