Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minOccurs="1" constraint for auc:AllResourceTotal element #148

Merged

Conversation

markborkum
Copy link
Contributor

This resolves a bug in XML generation using Soap4R-autogenerated code.

Specifically, the "minOccurs" constraint causes the XML generator to always write a auc:AllResourceTotals element, even if it does not contain any auc:AllResourceTotal child elements, resulting in a schema validation error.

This is/was the only occurrence of minOccurs="1" in the XSD file.

This resolves a bug in XML generation using Soap4R-autogenerated code.

Specifically, the "minOccurs" constraint causes the XML generator to always write a `auc:AllResourceTotals` element, even if it does not contain any `auc:AllResourceTotal` child elements, resulting in a schema validation error.

This is/was the only occurrence of `minOccurs="1"` in the XSD file.
@markborkum markborkum requested a review from nllong September 6, 2019 19:42
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I'll merge once CI passes. Thanks!

@nllong nllong merged commit e82aeca into develop Sep 9, 2019
@nllong nllong deleted the bugfix/remove-constraint-for-AllResourceTotals-element branch September 9, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants