Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spatial Unit Occupied Percentage #141

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Add Spatial Unit Occupied Percentage #141

merged 1 commit into from
Aug 9, 2019

Conversation

nllong
Copy link
Member

@nllong nllong commented Aug 8, 2019

No description provided.

@nllong nllong requested a review from markborkum August 8, 2019 20:41
markborkum
markborkum reviewed Aug 8, 2019
View reviewed changes
Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To harmonize with the definitions of preexisting elements, e.g., <FloorArea>, should the <SpatialUnit> element also include a <SpatialUnitsOccupiedValue> child element?

@nllong
Copy link
Member Author

nllong commented Aug 8, 2019

SpatialUnits are specified as <NumberOfUnits> or <UnitDensity>. I could see renaming <NumberOfUnits> to SpatialUnitValue, but then it is isn't clear when we are reporting UnitDensity.

@markborkum
Copy link
Contributor

@nllong Makes sense, thanks.

@nllong nllong merged commit db28cfd into develop Aug 9, 2019
@nllong nllong deleted the feature/spatial-units-occupied branch August 9, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markborkum markborkum markborkum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nllong @markborkum