Refactor Controls #120
Merged
Refactor Controls #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nllong
force-pushed
the
improvement/controls
branch
from
882d85a to
b74d7ca
Compare
jasondegraw
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
I pulled it locally to look at it in XMLSpy since it's a big change, and it looks pretty good to me. Since it is a big change, there may be some issues around the edges, but overall I'd say that'll be worth it in the end. This is the right way to go and fits in well with the rest of the schema, and it is a big improvement over what was there.
markborkum
reviewed
Aug 2, 2019
markborkum
reviewed
Aug 2, 2019
markborkum
reviewed
Aug 2, 2019
markborkum
reviewed
Aug 2, 2019
markborkum
requested changes
Aug 2, 2019
markborkum
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two proposals for refactoring the concept of controls in BSync. The options are in the LightingSystem and named Controls_1 and Controls_2. Make sure to review the proposal as it contains initial mappings.
It is best to checkout this branch and review it in a schema editor.