Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supriya comments apr16 #12

Merged
merged 4 commits into from
May 19, 2016
Merged

Supriya comments apr16 #12

merged 4 commits into from
May 19, 2016

Conversation

fieldkm
Copy link
Contributor

@fieldkm fieldkm commented May 13, 2016

No description provided.

Kristin Field-Macumber added 3 commits May 13, 2016 11:50
@fieldkm
Copy link
Contributor Author

fieldkm commented May 13, 2016

For some reason, the schema is showing very unhelpful diffs, even though my one change was very minor. I think it may have to do with the way XML Spy adds spaces/tabs vs. how the original file had them. Maybe I need to change a default setting? Anyway, we may want to correct this before I make other changes so that everything can have useful diffing possible. --Kristin

@nllong
Copy link
Member

nllong commented May 13, 2016

This broke the example files because the space IDs are in the examples. Do you want to clean those up too?

@fieldkm
Copy link
Contributor Author

fieldkm commented May 13, 2016

Sure, I can do this. Is that why the CircleCI test failed?

From: Nicholas Long [mailto:notifications@github.com]
Sent: Friday, May 13, 2016 2:19 PM
To: BuildingSync/schema
Cc: Field-Macumber, Kristin; Author
Subject: Re: [BuildingSync/schema] Supriya comments apr16 (#12)

This broke the example files because the space IDs are in the examples. Do you want to clean those up too?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com//pull/12#issuecomment-219148861

@nllong
Copy link
Member

nllong commented May 13, 2016

yep

@fieldkm
Copy link
Contributor Author

fieldkm commented May 17, 2016

@nllong is this ok now?

@nllong
Copy link
Member

nllong commented May 19, 2016

perfect. thanks!

@nllong nllong closed this May 19, 2016
@nllong nllong reopened this May 19, 2016
@nllong nllong merged commit a6a3343 into BuildingSync:develop May 19, 2016
@fieldkm fieldkm mentioned this pull request Jun 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fieldkm @nllong