Add <auc:PrimaryFuel> Element to Plants #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markborkum
changed the title
jasondegraw
suggested changes
Jun 28, 2019
There was a problem hiding this comment.
Users may need to specify a fuel, but the way to do that within the schema is to connect to a ResourceUse, which can already be done. This may be an area where the current implementation is too roundabout and needs to be streamlined, but for full generality here the solution needs to use ResouceUse.
|
@markborkum We're discussing this internally, it may be that the roundabout approach is not good enough here. We should have more concrete feedback later today. |
jasondegraw
approved these changes
Jul 1, 2019
|
Merging now, thanks @markborkum! |
jasondegraw
deleted the
feature/add-primary-fuel-to-heating-and-cooling-plants
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
proposals/2019/Add PrimaryFuel to HeatingPlantType and CoolingPlantType.mdfor details.