Skip to content

Commit

Permalink
Merge pull request #231 from BuildingSync/refactor/side-door-ids
Browse files Browse the repository at this point in the history 
Add choice for multiple auc:DoorIDs in auc:Side
  • Loading branch information
@macintoshpie
macintoshpie authored Sep 11, 2020
2 parents 3733c7d + fe88963 commit bdc967f
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 22 deletions.
54 changes: 32 additions & 22 deletions BuildingSync.xsd
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1180,28 +1180,16 @@
<xs:attribute name="IDref" type="xs:IDREF" use="required"/>
</xs:complexType>
</xs:element>
<xs:element name="DoorID" minOccurs="0">
<xs:annotation>
<xs:documentation>ID number of the door type associated with this side of the section.</xs:documentation>
</xs:annotation>
<xs:complexType>
<xs:sequence>
<xs:element name="FenestrationArea" minOccurs="0">
<xs:annotation>
<xs:documentation>Total area of this fenestration type. (ft2)</xs:documentation>
</xs:annotation>
<xs:complexType>
<xs:simpleContent>
<xs:extension base="xs:decimal">
<xs:attribute ref="auc:Source"/>
</xs:extension>
</xs:simpleContent>
</xs:complexType>
</xs:element>
</xs:sequence>
<xs:attribute name="IDref" type="xs:IDREF" use="required"/>
</xs:complexType>
</xs:element>
<xs:choice>
<xs:element ref="auc:DoorID" minOccurs="0"/>
<xs:element name="DoorIDs" minOccurs="0">
<xs:complexType>
<xs:sequence>
<xs:element ref="auc:DoorID" minOccurs="0" maxOccurs="unbounded"/>
</xs:sequence>
</xs:complexType>
</xs:element>
</xs:choice>
<xs:element name="ThermalZoneIDs" minOccurs="0">
<xs:annotation>
<xs:documentation>List of thermal zone IDs.</xs:documentation>
Expand Down Expand Up @@ -17555,4 +17543,26 @@
<xs:attribute name="IDref" type="xs:IDREF" use="required"/>
</xs:complexType>
</xs:element>
<xs:element name="DoorID">
<xs:annotation>
<xs:documentation>ID number of the door type associated with this side of the section.</xs:documentation>
</xs:annotation>
<xs:complexType>
<xs:sequence>
<xs:element name="FenestrationArea" minOccurs="0">
<xs:annotation>
<xs:documentation>Total area of this fenestration type. (ft2)</xs:documentation>
</xs:annotation>
<xs:complexType>
<xs:simpleContent>
<xs:extension base="xs:decimal">
<xs:attribute ref="auc:Source"/>
</xs:extension>
</xs:simpleContent>
</xs:complexType>
</xs:element>
</xs:sequence>
<xs:attribute name="IDref" type="xs:IDREF" use="required"/>
</xs:complexType>
</xs:element>
</xs:schema>
13 changes: 13 additions & 0 deletions proposals/2020/Allow Multiple Door IDs for Side.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Allow Multiple Doors for Side

## Overview

This proposal is to modify the `auc:Side` to allow an unbounded number of `auc:DoorID`s to be referenced

## Justification

Currently you can only reference one door ID for each `auc:Side`. This is an issue if a side of a building has multiple door types.

## Implementation

This proposal suggests the schema creates a choice between a single `auc:DoorID` (how things currently are), or `auc:DoorIDs` which contains an unbounded number of door IDs. This is non-breaking and the former choice could be dropped in the next major release.

0 comments on commit bdc967f

Please sign in to comment.