Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/remove schematron files #74

Merged
merged 4 commits into from
May 19, 2021

Conversation

macintoshpie
Copy link
Contributor

@macintoshpie macintoshpie commented May 18, 2021

context

We're moving schematron files into the use-cases repo.

changes

  • Delete old documentation and schematron files.
  • refactor generate_sch to default the assertion role to ERROR
  • refactor cli to support schemaVersion attribute when generating
  • remove cli commands specific to repo (e.g. generate_all)

Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sweet! Thanks for cleaning this all up 🧹. I'm eager to have the new use case repo up and running!

@macintoshpie
Copy link
Contributor Author

@nllong can you update the branch protection settings by removing these two status checks? These were necessary when the schematron was around but not anymore.
Screen Shot 2021-05-19 at 8 59 29 AM

@macintoshpie
Copy link
Contributor Author

Also I think we should make a new release after this, I would like to use the new features for generating sch in the use-cases repo

@nllong
Copy link
Member

nllong commented May 19, 2021

@nllong can you update the branch protection settings by removing these two status checks? These were necessary when the schematron was around but not anymore.
Screen Shot 2021-05-19 at 8 59 29 AM

done.

@nllong
Copy link
Member

nllong commented May 19, 2021

Also I think we should make a new release after this, I would like to use the new features for generating sch in the use-cases repo

🚀🤘

@macintoshpie macintoshpie merged commit ce5a5ed into develop May 19, 2021
@macintoshpie macintoshpie deleted the refactor/remove-schematron-files branch May 19, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants