Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new examples to version 2.3.0 #66

Merged
merged 6 commits into from
Mar 26, 2021

Conversation

JieXiong9119
Copy link
Contributor

  1. Add bsyncr use case (schematron, example, test function)
  2. Add examples and test functions for multiple use cases
    2.1. L000 audit + L100 OS pre-simulation
    2.2. L100 audit + bsyncr

JieXiong9119 and others added 4 commits March 11, 2021 15:10
1. Add bsyncr use case (schematron, example, test function)
2. Add examples and test functions for multiple use cases
2.1. L000 audit + L100 OS pre-simulation
2.2. L100 audit + bsyncr
To align with version 2.3.0
Copy link
Contributor

@corymosiman12 corymosiman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @JieXiong9119 - for both the 2.2.0 and 2.3.0 versions, can you add a bsyncr.csv file (similar to the others, see here for example and then use that to generate the schematron file? That's how we've been managing these, as it is a bear to deal with schematron files on their own :) Likely there should be no change to the bsyncr.sch file (maybe just ordering). Let me know if any of that is unclear, and kudos for writing schematron by hand.

csv files used to generate bsyncr schematron (for both v2.2.0 and v2.3.0)
@corymosiman12
Copy link
Contributor

@JieXiong9119 will you just add newlines at the end of the csv's (not sure why this isn't getting flagged by pre-commit... @macintoshpie thoughts?):
image

@JieXiong9119
Copy link
Contributor Author

@JieXiong9119 will you just add newlines at the end of the csv's (not sure why this isn't getting flagged by pre-commit... @macintoshpie thoughts?):
image

Manually done. I'm not sure why this is not fixed by the pre-commit.

Copy link
Contributor

@corymosiman12 corymosiman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 schnoice!

@JieXiong9119
Copy link
Contributor Author

@corymosiman12 I think it's ready to merge. I don't have a write access again (weird) so could you merge it?

@corymosiman12 corymosiman12 merged commit e102da6 into BuildingSync:develop Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants