Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for example files dropdown by version #164

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Conversation

kflemin
Copy link
Contributor

@kflemin kflemin commented Feb 17, 2022

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1877259587

  • 13 of 17 (76.47%) changed or added relevant lines in 2 files are covered.
  • 124 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.007%) to 43.245%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bsyncviewer/forms.py 7 8 87.5%
bsyncviewer/views.py 6 9 66.67%
Files with Coverage Reduction New Missed Lines %
.tox/python/lib/python3.6/site-packages/django/db/migrations/graph.py 1 54.24%
.tox/python/lib/python3.6/site-packages/charset_normalizer/api.py 123 7.66%
Totals Coverage Status
Change from base Build 1694751064: 0.007%
Covered Lines: 39276
Relevant Lines: 90823

💛 - Coveralls

@@ -36,6 +36,19 @@ class LoadXMLExample(forms.Form):

form_type = forms.CharField(widget=forms.HiddenInput(), initial='example')

def clean(self):

super(LoadXMLExample, self).clean()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fancy fancy... thanks for addressing!

@nllong nllong merged commit 0d643a7 into develop Feb 21, 2022
@nllong nllong deleted the validator-bug branch February 21, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BSync validator bug
3 participants