edge case fix for type references enums and unions enums #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kflemin
commented
Jan 12, 2022
kflemin
commented
- Fixes EndUse enumerations not showing up on schema viewer #156
Pull Request Test Coverage Report for Build 1689781762
💛 - Coveralls |
nllong
approved these changes
Jan 12, 2022
| @@ -43,6 +44,7 @@ def __init__(self): | |||
| self.simple_types = [] | |||
| self.name = "" | |||
| self.type = None | |||
| self.type_elements = [] | |||
There was a problem hiding this comment.
look like this is redundant (see Line #20)
| # if a referenced element wasn't found, and it wasn't a gbxml element, fail here | ||
| if found or type_ref.startswith('gbxml'): | ||
| continue | ||
| raise Exception("Couldn't find reference %s" % looking_for_type_name) |
| self.type_definitions.append(named_element) | ||
| # testing if this resolves the issue | ||
| # self.type_references.append(named_element) | ||
| if named_element.type.startswith("auc:"): |
There was a problem hiding this comment.
which cases don't have auc:? Just gbxml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.