Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validator file options #158

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Fix validator file options #158

merged 2 commits into from
Jan 6, 2022

Conversation

haneslinger
Copy link
Contributor

Answers issue #155

Thanks for the help all!

Previously, LoadXMLExample.file_name always showed the files for the current schema version. Now, LoadXMLExample.file_name contains all the files for all the schema versions, then filters the irrelevant one out on load and schema version change.

Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!


schemaDropdown = document.getElementById("schema_dropdown")
schema_dropdown.addEventListener("change", setFileOptions)
setFileOptions();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@coveralls
Copy link

coveralls commented Jan 6, 2022

Pull Request Test Coverage Report for Build 1665304626

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 43.25%

Files with Coverage Reduction New Missed Lines %
.tox/python/lib/python3.6/site-packages/django/forms/fields.py 7 42.09%
Totals Coverage Status
Change from base Build 1665303336: 0.02%
Covered Lines: 39209
Relevant Lines: 90657

💛 - Coveralls

@nllong nllong merged commit 0b81ad0 into develop Jan 6, 2022
@nllong nllong deleted the fix-validator-file-options branch January 6, 2022 23:20
@kflemin
Copy link
Contributor

kflemin commented Jan 6, 2022

sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants