Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix versions of examples #151

Merged
merged 3 commits into from
Dec 29, 2021
Merged

Fix versions of examples #151

merged 3 commits into from
Dec 29, 2021

Conversation

nllong
Copy link
Member

@nllong nllong commented Dec 28, 2021

The validation examples were still the old versions of the schema.

@coveralls
Copy link

coveralls commented Dec 28, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1632165814

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 43.245%
Totals Coverage Status
Change from base Build 1632164430: 0.001%
Covered Lines: 39183
Relevant Lines: 90608
💛 - Coveralls

JieXiong9119
JieXiong9119 reviewed Dec 29, 2021
View reviewed changes
Copy link
Contributor

@JieXiong9119 JieXiong9119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we don't update the v2.3.0 examples to v2.4.0?

@nllong
Copy link
Member Author

nllong commented Dec 29, 2021

Because they are in the BSync V2.3 directory, so we have to keep the older ones around.

JieXiong9119
JieXiong9119 approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@JieXiong9119 JieXiong9119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see.. Looks good!

@nllong nllong merged commit 94c40fc into develop Dec 29, 2021
@nllong nllong deleted the fix-versions-of-examples branch December 29, 2021 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JieXiong9119 JieXiong9119 JieXiong9119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nllong @coveralls @JieXiong9119