Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BEDES Mapping #146

Merged
merged 3 commits into from
Dec 28, 2021
Merged

Update BEDES Mapping #146

merged 3 commits into from
Dec 28, 2021

Conversation

haneslinger
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Dec 28, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1631771481

  • 13 of 13 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1226 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.1%) to 43.229%
Files with Coverage Reduction New Missed Lines %
.tox/python/lib/python3.6/site-packages/charset_normalizer/models.py 10 38.97%
.tox/python/lib/python3.6/site-packages/pkg_resources/_vendor/packaging/requirements.py 13 70.13%
.tox/python/lib/python3.6/site-packages/pkg_resources/_vendor/packaging/_structures.py 15 55.0%
.tox/python/lib/python3.6/site-packages/pkg_resources/_vendor/packaging/markers.py 41 45.24%
.tox/python/lib/python3.6/site-packages/pkg_resources/_vendor/packaging/utils.py 47 20.9%
.tox/python/lib/python3.6/site-packages/charset_normalizer/cd.py 51 14.72%
.tox/python/lib/python3.6/site-packages/charset_normalizer/utils.py 75 29.41%
.tox/python/lib/python3.6/site-packages/pkg_resources/_vendor/packaging/version.py 81 60.43%
.tox/python/lib/python3.6/site-packages/charset_normalizer/md.py 89 21.98%
.tox/python/lib/python3.6/site-packages/charset_normalizer/api.py 122 7.87%
Totals Coverage Status
Change from base Build 1478288064: -0.1%
Covered Lines: 39169
Relevant Lines: 90608
💛 - Coveralls

@JieXiong9119
Copy link
Contributor

@nllong It turned out that the new version of BEDES does have duplicated List-Option (enumeration) names, so we loosed the constraint of uniqueness for querying term, 'definition, urlandrelated_term_uuid(in fact we only kept theuuidunique). Now the--save_to_db` command will not reparse but only push the mapping to db.

@haneslinger @JieXiong9119
Update bsyncviewer/management/commands/bedes.py
0e76036 
Co-authored-by: Jie Xiong <69597597+JieXiong9119@users.noreply.github.com>
nllong
nllong reviewed Dec 28, 2021
View reviewed changes
bsyncviewer/models/bedes_models.py
@@ -24,7 +24,7 @@ class BedesMapping(models.Model):
# Bedes Enumeration
class BedesEnumeration(models.Model):
content_uuid = models.CharField(max_length=100, unique=True)
term = models.CharField(max_length=100, unique=True)
term = models.CharField(max_length=100)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@haneslinger @nllong
Update bsyncviewer/management/commands/bedes.py
474e5b0 
Co-authored-by: Nicholas Long <1907354+nllong@users.noreply.github.com>
@haneslinger haneslinger merged commit b6592ef into develop Dec 28, 2021
@haneslinger haneslinger deleted the Updated-BEDES-Mapping branch December 28, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JieXiong9119 JieXiong9119 JieXiong9119 approved these changes

@kflemin kflemin Awaiting requested review from kflemin

@nllong nllong Awaiting requested review from nllong

Assignees

@haneslinger haneslinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haneslinger @coveralls @JieXiong9119 @nllong